Omniscia Arcade XYZ Audit
Code Style
Code Style
During the manual portion of the audit, we identified 27 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| AIV-01C |  |  | Loop Iterator Optimization |
| AIV-02C | | | Optimization of if Structure |
| ABV-01C | | | Ineffectual Usage of Safe Arithmetics |
| ABV-02C | | | Loop Iterator Optimizations |
| AVT-01C | | | Loop Iterator Optimization |
| AVT-02C | |  | Misconception of Re-Entrancy Attack Vectors |
| AVT-03C | | | Optimization of if-else Structure |
| AVT-04C | | | Potential Enhancement of Functionality |
| AVT-05C | | | Potential Optimization of Project Structure |
| CWT-01C | | | Inefficient mapping Lookups |
| FCR-01C | | | Redundant Parenthesis Statements |
| FCR-02C | | | Suboptimal Struct Declaration Styles |
| LCE-01C | | | Ineffectual Usage of Safe Arithmetics |
| LCE-02C | | | Inefficient Loop Limit Evaluation |
| LCE-03C | | | Inefficient mapping Lookups |
| LCE-04C | | | Loop Iterator Optimizations |
| LCE-05C | | | Optimization of Assignments |
| LCE-06C | | | Suboptimal Struct Declaration Style |
| LLY-01C | | | Inefficient Tight Packing of Structs |
| OCR-01C | | | Ineffectual Usage of Safe Arithmetics |
| OCR-02C | | | Loop Iterator Optimizations |
| OER-01C | | | Potential Optimization of Project Structure |
| PNE-01C | |  | Inefficient Renunciation of Role |
| PVR-01C | | | Loop Iterator Optimization |
| PVR-02C | | | Redundant Usage of SafeCast |
| PVR-03C | | | Undocumented Predicate Feature |
| RCR-01C | | | Redundant Conditional Evaluation |