FeeController Code Style Findings

FCR-01C: Redundant Parenthesis Statements

Type	Severity	Location
Code Style		FeeController.sol:L128-L136, L146-L151

Description:

The referenced statements are redundantly wrapped in parenthesis' (()).

Example:

Copy
128return (
129    FeesOrigination (
130        loanFees[FL_01],
131        loanFees[FL_02],
132        loanFees[FL_05],
133        loanFees[FL_06],
134        loanFees[FL_07]
135    )
136);

Recommendation:

We advise them to be safely omitted, increasing the legibility of the codebase.

Alleviation (7a4e1dc948e94ded7385dbb74818bcf93ecc207c):

The redundant parenthesis statements have been properly omitted, optimizing the code's legibility.

FCR-02C: Suboptimal Struct Declaration Styles

Type	Severity	Location
Code Style		FeeController.sol:L129-L135, L147-L150

Description:

The linked declaration styles of the referenced structs are using index-based argument initialization.

Example:

Copy
129FeesOrigination (
130    loanFees[FL_01],
131    loanFees[FL_02],
132    loanFees[FL_05],
133    loanFees[FL_06],
134    loanFees[FL_07]
135)

Recommendation:

We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.

Alleviation (7a4e1dc948e94ded7385dbb74818bcf93ecc207c):

Both struct instantiations have been replaced by their key-value declaration style, greatly increasing their legibility.