PunksVerifier Static Analysis Findings

PVR-01S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		PunksVerifier.sol:L38-L40

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
38constructor(address _punks) {
39    punks = IPunks(_punks);
40}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (7a4e1dc948e94ded7385dbb74818bcf93ecc207c):

The Arcade XYZ team evaluated this exhibit and opted to retain the current behaviour of the codebase.