Omniscia Badai Tech Audit
BadAI Code Style Findings
BadAI Code Style Findings
BAI-01C: Generic Typographic Mistake
Type | Severity | Location |
---|---|---|
Code Style | ![]() | BadAI.sol:L8 |
Description:
The referenced line contains a typographical mistake (i.e. private
variable without an underscore prefix) or generic documentational error (i.e. copy-paste) that should be corrected.
Example:
8import {ERC20TokenMetadata} from "./IERC20TokenMetadata.sol";
Recommendation:
We advise this to be done so to enhance the legibility of the codebase.
Alleviation (d639d227f8b8d90dbd9813ab9d7a5cbee34dd9b1):
The relevant interface
has had its name properly prefixed with the I
sign indicating that it is an interface
declaration.
BAI-02C: Repetitive Value Literal
Type | Severity | Location |
---|---|---|
Code Style | ![]() | BadAI.sol:L16 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
16_mint(msg.sender, 1000000000 ether);
Recommendation:
We advise it to be set to a constant
variable instead, optimizing the legibility of the codebase.
In case the constant
has already been declared, we advise it to be properly re-used across the code.
Alleviation (2ef12e6885819c0633d60cc0b6d226e3abead257):
The Badai Tech team evaluated this exhibit and stated that they do not intend the total supplies of the two assets to correlate, rendering the recommendation to be inapplicable.