Omniscia Badai Tech Audit

IndexPool Static Analysis Findings

IndexPool Static Analysis Findings

IPL-01S: Inexistent Sanitization of Input Address

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

contracts/IndexPool.sol
23constructor(address _indexToken) Ownable(msg.sender) {
24 indexToken = IERC20Burnable(_indexToken);
25}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.

Alleviation (d639d227f8b8d90dbd9813ab9d7a5cbee34dd9b1):

The input _indexToken address argument of the IndexPool::constructor function is adequately sanitized as non-zero in the latest in-scope revision of the codebase, addressing this exhibit.