Omniscia Boson Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 9 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
DRF-01CCode Repetition
DRF-02CInefficient mapping Lookups
DRF-03CRedundant Parenthesis Statements
ECF-01CRedundant Conditional Validation
ECF-02CRedundant Validation of Seller Parameters
FBE-01CInefficient Handling of Dispute Resolution Refund
OBE-01CRedundant Conditional Validation
OBE-02CUnspecified Revert Conditions
PBE-01CRedundant Conditional Validation