Omniscia Boson Protocol Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Boson Protocol's BPIP implementations.

As the audit at hand represents a code delta, intricate care was put into ensuring that the previously established security guarantees remain upheld and that the new features that have been introduced to not result in retroactive vulnerabilities.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple significant vulnerabilities within the system which could have had severe ramifications to its overall operation; for more information, kindly consult the audit report's summary as well as the major exhibits contained within.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to an exemplary extent, containing extensive in-line documentation and explicit error cases for all newly introduced functions.

A total of 17 findings were identified over the course of the manual review of which 8 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
DRF-01MImproper Validation of Payment
EIP-01MLimiting Signature Verification Process
ECF-01MIncorrect Message Sender Emission
ECF-02MInexistent Validation of Mutualizer Interface Conformity
ECF-03MFee Mutualizer Fund Extraction via Re-Entrancy
FBE-01MDeprecated Approval Function
FBE-02MInsecure Integration of Dispute Resolution Mutualizer
OHF-01MInexistent Validation of Mutualizer Interface Conformity