Omniscia Boson Protocol Audit

OfferBase Static Analysis Findings

OfferBase Static Analysis Findings

OBE-01S: Literal Equality of bool Variable

Description:

The linked bool comparison is performed between a variable and a bool literal.

Example:

contracts/protocol/bases/OfferBase.sol
272if (!success || data.length != 32 || abi.decode(data, (bool)) == false) {

Recommendation:

We advise the bool variable to be utilized directly either in its negated (!) or original form.

Alleviation (efd5d1a8f23c3bca7c25273ea4c912a367250119):

The referenced boolean comparison has been optimized as advised.