Omniscia Evergon Labs Audit

Code Style

Code Style

During the manual portion of the audit, we identified 23 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
AML-01CCombination of Logical Clauses
AML-02CDeprecated Revert Statements
AMS-01CNon-Standard Storage Slot Definition
BDO-01CBytecode Size Optimization
BDO-02CIneffectual Usage of Safe Arithmetics
BDO-03CRedundant Parenthesis Statement
ERN-01CInefficient Application of Modifier
FEC-01CRedundant Import of Implementation
FER-01CRedundant Import of Implementation
FFY-01CRedundant Calculations
FFY-02CSuboptimal Struct Declaration Style
FTD-01CRedundant Constructor Declaration
OES-01COptimization of Conditionals
OIS-01CRepetitive Value Literal
OPY-01CGeneric Typographic Mistake
OPY-02CSuboptimal Struct Declaration Style
OSS-01CNon-Standard Storage Slot Definition
OSS-02CRedundant Import of Logic Implementation
TWT-01CIneffectual Usage of Safe Arithmetics
WRE-01CIneffectual Usage of Safe Arithmetics
WRE-02CInefficient mapping Lookups
WRE-03CSuboptimal Conditional
WRE-04CUnreachable Code