Omniscia Evergon Labs Audit
OmnichainProxy Code Style Findings
OmnichainProxy Code Style Findings
OPY-01C: Generic Typographic Mistake
| Type | Severity | Location |
|---|---|---|
| Code Style |  | OmnichainProxy.sol:L88 |
Description:
The referenced line contains a typographical mistake (i.e. private variable without an underscore prefix) or generic documentational error (i.e. copy-paste) that should be corrected.
Example:
contracts/OmnichainProxy.sol
88APPROVE_DATA_MANGER,Recommendation:
We advise this to be done so to enhance the legibility of the codebase.
Alleviation (c6b23c23d8bcd8cce85049ad959cbd711a37126b):
The APPROVE_DATA_MANGER enum has been properly renamed to APPROVE_DATA_MANAGER, addressing this exhibit.
OPY-02C: Suboptimal Struct Declaration Style
| Type | Severity | Location |
|---|---|---|
| Code Style | | OmnichainProxy.sol:L369 |
Description:
The linked declaration style of a struct is using index-based argument initialization.
Example:
contracts/OmnichainProxy.sol
369MessagingFee memory fee = MessagingFee(msg.value, 0);Recommendation:
We advise the key-value declaration format to be utilized instead, greatly increasing the legibility of the codebase.
Alleviation (c6b23c23d8bcd8cce85049ad959cbd711a37126b):
The key-value declaration style has been properly utilized for the relevant struct entry, optimizing the code's legibility.