Omniscia Gnosis Guild Audit
Zodiac Modifier Roles Security Audit
Audit Report Revisions
Commit Hash | Date | Audit Report Hash |
---|---|---|
23b782f781 | May 9th 2023 | 916e3ac17f |
Audit Overview
We were tasked with performing an audit of the Gnosis Guild codebase and in particular their specialized access control module meant to enforce access control of various Gnosis-related modules.
The system enables users to enforce a significantly granular level of access control that differs and adapts to each transaction's target as well as function selector.
Over the course of the audit, we identified contradictory behaviour in the XOR
operator supported by the conditions in the system.
We advise the Gnosis Guild team to closely evaluate all minor-and-above findings identified in the report and promptly remediate them as well as consider all optimizational exhibits identified in the report.
Post-Audit Conclusion
The Gnosis Guild team iterated through all findings within the report and provided us with a revised commit hash to evaluate all exhibits on.
We evaluated all alleviations performed by Gnosis Guild and have identified that all exhibits have been adequately dealt with no outstanding issues remaining in the report.
Contracts Assessed
Files in Scope | Repository | Commit(s) |
---|---|---|
BufferPacker.sol (BPR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Core.sol (CER) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Consumptions.sol (CSN) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Decoder.sol (DRE) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Integrity.sol (IYT) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
MultiSendUnwrapper.sol (MSU) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Packer.sol (PRE) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Periphery.sol (PYR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
PermissionLoader.sol (PLR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
PermissionBuilder.sol (PBR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
PermissionChecker.sol (PCR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
PermissionTracker.sol (PTR) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Roles.sol (RSE) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Types.sol (TSE) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Types.sol (TSP) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Topology.sol (TYG) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
WriteOnce.sol (WOE) | zodiac-modifier-roles | a9f65e8f05, 23b782f781 |
Audit Synopsis
Severity | Identified | Alleviated | Partially Alleviated | Acknowledged |
---|---|---|---|---|
![]() | 0 | 0 | 0 | 0 |
![]() | 27 | 14 | 0 | 13 |
![]() | 2 | 2 | 0 | 0 |
![]() | 2 | 2 | 0 | 0 |
![]() | 0 | 0 | 0 | 0 |
During the audit, we filtered and validated a total of 3 findings utilizing static analysis tools as well as identified a total of 28 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they can introduce potential misbehaviours of the system as well as exploits.
The list below covers each segment of the audit in depth and links to the respective chapter of the report: