Omniscia Gnosis Guild Audit

Zodiac Modifier Roles Security Audit

Audit Report Revisions

Commit HashDateAudit Report Hash
23b782f781May 9th 2023916e3ac17f

Audit Overview

We were tasked with performing an audit of the Gnosis Guild codebase and in particular their specialized access control module meant to enforce access control of various Gnosis-related modules.

The system enables users to enforce a significantly granular level of access control that differs and adapts to each transaction's target as well as function selector.

Over the course of the audit, we identified contradictory behaviour in the XOR operator supported by the conditions in the system.

We advise the Gnosis Guild team to closely evaluate all minor-and-above findings identified in the report and promptly remediate them as well as consider all optimizational exhibits identified in the report.

Post-Audit Conclusion

The Gnosis Guild team iterated through all findings within the report and provided us with a revised commit hash to evaluate all exhibits on.

We evaluated all alleviations performed by Gnosis Guild and have identified that all exhibits have been adequately dealt with no outstanding issues remaining in the report.

Contracts Assessed

Files in ScopeRepositoryCommit(s)
BufferPacker.sol (BPR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Core.sol (CER)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Consumptions.sol (CSN)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Decoder.sol (DRE)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Integrity.sol (IYT)zodiac-modifier-rolesa9f65e8f05,
23b782f781
MultiSendUnwrapper.sol (MSU)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Packer.sol (PRE)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Periphery.sol (PYR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
PermissionLoader.sol (PLR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
PermissionBuilder.sol (PBR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
PermissionChecker.sol (PCR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
PermissionTracker.sol (PTR)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Roles.sol (RSE)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Types.sol (TSE)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Types.sol (TSP)zodiac-modifier-rolesa9f65e8f05,
23b782f781
Topology.sol (TYG)zodiac-modifier-rolesa9f65e8f05,
23b782f781
WriteOnce.sol (WOE)zodiac-modifier-rolesa9f65e8f05,
23b782f781

Audit Synopsis

SeverityIdentifiedAlleviatedPartially AlleviatedAcknowledged
0000
2714013
2200
2200
0000

During the audit, we filtered and validated a total of 3 findings utilizing static analysis tools as well as identified a total of 28 findings during the manual review of the codebase. We strongly recommend that any minor severity or higher findings are dealt with promptly prior to the project's launch as they can introduce potential misbehaviours of the system as well as exploits.

The list below covers each segment of the audit in depth and links to the respective chapter of the report: