Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Gnosis Guild's specialized access control Roles module.

As the project at hand implements a customized access control mechanism with specialized encoding mechanisms and a multi-purpose structure, intricate care was put into ensuring that the access flow within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a vulnerability within the system's XOR logical condition implementation which could have had moderate ramifications to its overall operation.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend it to be expanded at certain complex points such as the hard-coded offsets in use throughout the codebase.

A total of 28 findings were identified over the course of the manual review of which 6 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

ID	Severity	Addressed	Title
IYT-01M			Weak Validation of Children Counts
IYT-02M			Weak Validation of Comparator Values
PCR-01M			Discrepant XOR Behaviour
TYG-01M			Potentially Invalidated Assumption
TSE-01M			Potentially Improper Function Mutability
WOE-01M			Unsafe Casting Operation