Omniscia Gnosis Guild Audit
Code Style
Code Style
During the manual portion of the audit, we identified 22 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BPR-01C |  |  | Loop Iterator Optimization |
| CSN-01C | |  | Inefficient Lookup Operation of Consumptions |
| IYT-01C | | | Content Validation Grouping |
| IYT-02C | | | Loop Iterator Optimizations |
| IYT-03C | | | Redundant Validation of Sub-Type Tree |
| MSU-01C | | | Deprecated if-revert Pattern |
| MSU-02C | | | Non-Standard Definition of Function Signature |
| PRE-01C | | | Loop Iterator Optimizations |
| PRE-02C | | | Optimization of Array Iteration |
| PYR-01C | | | Redundant Code Duplication |
| PBR-01C | | | Suboptimal Struct Declaration Styles |
| PCR-01C | |  | Inefficient Iteration of Child Conditions |
| PCR-02C | | | Optimization of Data Extraction |
| PTR-01C | | | Inefficient mapping Lookups |
| RSE-01C | | | Inefficient Transfer of Ownership |
| RSE-02C | | | Loop Iterator Optimization |
| TYG-01C | | | Ineffectual Usage of Safe Arithmetics |
| TYG-02C | | | Loop Iterator Optimization |
| TSP-01C | | | Incorrect Grouping of EqualToAvatar Operation (Documentation) |
| TSE-01C | | | Multiple Top-Level Declarations |
| TSP-02C | | | Suboptimal Documentation of Enum |
| WOE-01C | | | Multiple Top-Level Declarations |