Types Code Style Findings

TSE-01C: Multiple Top-Level Declarations

Type	Severity	Location
Code Style		Types.sol:L6, L15, L24

Description:

The referenced file contains multiple top-level declarations that decrease the legibility of the codebase.

Example:

Copy
6struct UnwrappedTransaction {
7    Enum.Operation operation;
8    address to;
9    uint256 value;
10    // We wanna deal in calldata slices. We return location, let invoker slice
11    uint256 dataLocation;
12    uint256 dataSize;
13}
14
15interface ITransactionUnwrapper {
16    function unwrap(
17        address to,
18        uint256 value,
19        bytes calldata data,
20        Enum.Operation operation
21    ) external view returns (UnwrappedTransaction[] memory result);
22}
23
24interface ICustomCondition {

Recommendation:

We advise all highlighted top-level declarations to be split into their respective code files, avoiding unnecessary imports as well as increasing the legibility of the codebase.

Alleviation:

The Gnosis Guild team evaluated this exhibit and has opted to not apply a remediation for it in the current iteration of the codebase.