Omniscia Gnosis Guild Audit
PermissionBuilder Code Style Findings
PermissionBuilder Code Style Findings
PBR-01C: Suboptimal Struct Declaration Styles
| Type | Severity | Location |
|---|---|---|
| Code Style | ![]() | PermissionBuilder.sol:L63-L66, L77-L80, L91-L94 |
Description:
The linked declaration styles of the referenced structs are using index-based argument initialization.
Example:
packages/evm/contracts/PermissionBuilder.sol
63roles[roleKey].targets[targetAddress] = TargetAddress(64 Clearance.Target,65 options66);Recommendation:
We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.
Alleviation:
The three referenced struct declarations have been adjusted to use the key-value declaration style, greatly optimizing their legibility.
