CrossMint1155 Manual Review Findings

CM5-01M: Redundant Declaration

Description:

The _beforeTokenTransfer implementation of ERC1155 is already a no-op and is again coded as such.

Example:

Copy
167function _beforeTokenTransfer(
168  address operator,
169  address from,
170  address to,
171  uint256[] memory ids,
172  uint256[] memory amounts,
173  bytes memory data
174) internal virtual override {
175  // noop
176}

Recommendation:

We advise the implementation to be omitted entirely as it is functionally equivalent to the overridden one.

Alleviation:

The _beforeTokenTransfer function was safely omitted from the codebase.