Omniscia Seen Haus Audit

MarketClientProxy Code Style Findings

MarketClientProxy Code Style Findings

MCP-01C: Redundant payable Constructor

TypeSeverityLocation
Language SpecificInformationalMarketClientProxy.sol:L47

Description:

The constructor of the contract is marked as payable.

Example:

contracts/market/client/MarketClientProxy.sol
43constructor(
44 address _accessController,
45 address _marketController,
46 address _impl
47) payable {

Recommendation:

If this is indeed desired, we advise documentation to be added to support it. Otherwise, we advise it to be omitted from the codebase as it can lead to loss of funds.

Alleviation:

The payable specifier has been safely removed from the constructor.