Omniscia Seen Haus Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Seen Haus's codebase.
As the project at hand implements an NFT sale and auction system, intricate care was put into ensuring that the flow of funds and assets within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple re-entrancy vulnerabilities within the system which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Seen Haus team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a great extent.
A total of 24 findings were identified over the course of the manual review of which 13 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
ABF-01M | Major | Yes | Improper Sanitization of Start Time |
ABF-02M | Minor | Yes | Inexistent Sanitization of Auction Duration |
AEF-01M | Minor | Yes | Potentially Incorrect Physical Ticket Workflow |
ARF-01M | Major | Yes | Ineffectual Protection & Bid Refund Re-Entrancy |
ARF-02M | Minor | Yes | Deprecated Native Asset Transfer |
LTR-01M | Minor | Yes | Inexistent Ticket Cleanup |
MHB-01M | Minor | Yes | Deprecated Native Asset Transfer |
MHB-02M | Minor | Yes | Improper Fee Deduction |
MHB-03M | Minor | Yes | Non-Standard Application of Escrow Fee |
SBF-01M | Medium | Yes | Inexistent Sanitization of Sale Start |
SBF-02M | Minor | Yes | Inexistent Validation of Proper Supply |
SEF-01M | Major | Yes | Double Payout Vulnerability |
SRF-01M | Medium | Yes | Inexistent Validation of Remaining Supply |