Omniscia Seen Haus Audit

Code Style

Code Style

During the manual portion of the audit, we identified 11 optimizations that can be applied to the codebase that will decrease the gas-cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ARF-01CInformationalYesInexistent Visibility Specifier
ARF-02CInformationalYesRedundant Value Assignment
IIO-01CInformationalYesInterface ID Optimization
ITR-01CInformationalYesImproper Initialization
MCL-01CInformationalYesInexplicable Deviancy
MCP-01CInformationalYesRedundant payable Constructor
SEF-01CInformationalYesRedundant Evaluation
SCS-01CInformationalNoInefficient Hash Constants
SHN-01CInformationalYesImproper Initialization
SHN-02CInformationalYesNon-Standard Storage Declaration
SHN-03CInformationalYesRedundant import Statement

Prev

Manual Review

Next

MarketHandlerBase.sol (MHB-S)