MarketClientLib Code Style Findings

MCL-01C: Inexplicable Deviancy

Description:

All contracts in the system are conforming to the EIP-1967 storage slot specification apart from this instance.

Example:

Copy
28/**
29 * @dev Storage slot with the address of the Seen.Haus AccessController
30 * This is obviously not a standard EIP-1967 slot.
31 */
32bytes32 internal constant PROXY_SLOT = keccak256('Seen.Haus.MarketClientProxy');

Recommendation:

We advise this instance to also conform to the standard as there is no justification as to why it should deviate.

Alleviation:

The Seen Haus team stated that this deviation is intentional to allow flexibility in the storage structures used by the project. As a result, we consider this exhibit null.