Omniscia Seen Haus Audit
MarketHandlerBase Static Analysis Findings
MarketHandlerBase Static Analysis Findings
MHB-01S: Redundant Comparison of bool
Variable
Type | Severity | Location |
---|---|---|
Code Style | Informational | MarketHandlerBase.sol:L135, L137, L205 |
Description:
The linked statements perform a direct comparison between a bool
literal and a bool
variable.
Example:
contracts/market/handlers/MarketHandlerBase.sol
205if (supported == true) {
Recommendation:
We advise the bool
variable to be used directly instead in either its negated (!
) form or its normal one depending on the need.
Alleviation:
All linked instances were properly updated to use the bool
variable directly. We should note that the former two had their error message removed, a pattern we advise against.