Omniscia Sova Network Audit

Code Style

Code Style

During the manual portion of the audit, we identified 30 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
BRR-01CInexplicable Usage of Contract Declaration
BSY-01CInefficient Import of Logic Implementation
CRM-01CInefficient Logic Contract Import
GME-01CInconsistent Off-Chain Related Integration
GME-02CNon-Standard Library Usage
GMR-01CInefficient Array Resize Operation
GMR-02CInefficient mapping Lookups
GMR-03CRedundant Casting of Enum
KRH-01CInefficient Function Body
KRH-02CRedundant Code Duplication
LRM-01CInefficient Logic Contract Import
MWR-01CInefficient Hook Reads
MWR-02CPotentially Incorrect Allowance Requirement
MWR-03CRedundant Withdrawal Override
MWW-01CPotential Optimization of Nonce Consumption
POR-01CInefficient Event Emission
RSY-01CInefficient Imports of Logic Implementations
RMD-01CInefficient Logic Contract Import
RMR-01CInefficient Conditional Structure
RMR-02CMisleading Constant Documentation
RMR-03CRedundant Inclusion of Role
REE-01CIneffectual Usage of Safe Arithmetics
REE-02CInefficient Loop Limit Evaluation
REE-03CInefficient mapping Lookups
REE-04CPotentially Inefficient Shift Operation
RWA-01CInefficient Hook Activity Tracking
RWA-02CInefficient mapping Lookups
RWA-03CNon-Standard Library Usage
RWA-04CPotentially Redundant Shift Operation
RWA-05CRepetitive Value Literal

Prev

Manual Review

Next

BasicStrategy.sol (BSY-S)