Omniscia Sova Network Audit

BasicStrategy Code Style Findings

BasicStrategy Code Style Findings

BSY-01C: Inefficient Import of Logic Implementation

Description:

The referenced import statement will import the ERC20 implementation into the BasicStrategy contract yet will utilize it as an interface.

Example:

src/strategy/BasicStrategy.sol
4import {ERC20} from "solady/tokens/ERC20.sol";

Recommendation:

We advise a proper interface to be utilized instead, optimizing the code's legibility and bytecode size.

Alleviation (e4d6885477):

The Sova Network team specified that they addressed this issue in commit aa7f14240d5c4d8f2cc5efc7519dc905529379e5 partially, however, the commit is not present in the GitHub repository that is part of this audit engagement rendering the exhibit partially addressed.

Alleviation (08da17ef72):

The optimization has now been correctly applied by removing the redundant ERC20 import from the contract.