Omniscia Sova Network Audit

ReportedStrategy Code Style Findings

ReportedStrategy Code Style Findings

RSY-01C: Inefficient Imports of Logic Implementations

Description:

The referenced import statements will import the ERC20 and BaseReporter implementations into the ReportedStrategy contract yet will utilize both as interface declarations.

Example:

src/strategy/ReportedStrategy.sol
5import {BaseReporter} from "../reporter/BaseReporter.sol";

Recommendation:

We advise a proper interface to be utilized in place of each instead, optimizing the code's legibility and bytecode size.

Alleviation (e4d6885477):

The BaseReporter import has been corrected, however, the ERC20 implementation remains imported rendering the exhibit partially addressed.

Alleviation (08da17ef72):

The optimization has now been correctly applied by removing the redundant ERC20 import from the contract.