Omniscia Steer Protocol Audit
Code Style
Code Style
During the manual portion of the audit, we identified 23 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| BLM-01C |  |  | Inexistent Error Messages |
| BLM-02C | |  | Non-Standard Gap Declaration |
| BLM-03C | | | Relocation of Validation Check |
| BLM-04C | | | Sub-Optimal Data Types |
| DJS-01C | | | Improper Toggle Terminology |
| IGE-01C | | | Inexistent Error Messages |
| IGT-01C | | | Redundant Duplicate Implementation |
| ORO-01C | | | Direct Return of Conditional Evaluation |
| SPL-01C | |  | Generic Typographic Mistake |
| SRS-01C | | | Generic Typographic Mistakes |
| SRS-02C | | | Inefficient Mapping System |
| SRS-03C | | | Inefficient mapping Lookups |
| SGE-01C | | | Generic Typographic Mistake |
| STN-01C | | | Redundant Invocation of Getter Function |
| SRY-01C | | | Optimization of Pointer Data Location |
| SRY-02C | | | Suboptimal Struct Declaration Style |
| TVR-01C | | | Inexistent Error Message |
| TVR-02C | | | Variable Mutability Specifiers (Immutable) |
| TVR-03C | | | Variable Optimization |
| VRY-01C | | | Suboptimal Struct Declaration Style |
| WRY-01C | | | Improper Emission of Events |
| WRY-02C | | | Inefficient mapping Lookups |
| WRY-03C | | | Inexistent Error Message |