Omniscia Steer Protocol Audit
InternalGovernanceTimelock Code Style Findings
InternalGovernanceTimelock Code Style Findings
IGT-01C: Redundant Duplicate Implementation
Type | Severity | Location |
---|---|---|
Code Style | InternalGovernanceTimelock.sol:L9-L34 |
Description:
The code implementation of InternalGovernanceTimelock
is identical to the implementation of SteerGovernanceTimelock
.
Example:
contracts/InternalGovernanceTimelock.sol
9contract InternalGovernanceTimelock is10 Initializable,11 TimelockControllerUpgradeable,12 OwnableUpgradeable,13 UUPSUpgradeable14{15 /// @custom:oz-upgrades-unsafe-allow constructor16
17 constructor() initializer {}18
19 function initialize(20 uint256 minDelay,21 address[] memory proposers,22 address[] memory executors23 ) public initializer {24 __TimelockController_init(minDelay, proposers, executors);25 __Ownable_init();26 __UUPSUpgradeable_init();27 }28
29 function _authorizeUpgrade(address newImplementation)30 internal31 override32 onlyOwner33 {}34}
Recommendation:
We advise either of the two to be omitted from the codebase to reduce bloat.
Alleviation (200f275c40cbd4798f4a416c044ea726755d4741):
The contract has been removed from the codebase as per our recommendation.