Omniscia Steer Protocol Audit
BundleRegistry Static Analysis Findings
BundleRegistry Static Analysis Findings
BRY-01S: Inexistent Event Emission
Type | Severity | Location |
---|---|---|
Language Specific | BundleRegistry.sol:L94-L99 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/BundleRegistry.sol
94function pauseAdapter(bytes32 _adapter, bool _remainActive)95 external96 onlyOwner97{98 bundles[_adapter].active = _remainActive;99}
Recommendation:
We advise an event
to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (200f275c40cbd4798f4a416c044ea726755d4741):
The pauseAdapter
function (now renamed setAdapterState
) emits a newly defined BundleStateChanged
event thus alleviating this exhibit.