Omniscia Steer Protocol Audit

Manual Review

Manual Review

A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Steer Protocol's core implementation.

As the project at hand implements multiple protocol implementations, intricate care was put into ensuring that the flow of funds & assets within the system conforms to the specifications and restrictions laid forth within the protocol's specification.

We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed multiple vulnerabilities of all severities within the system which could have had moderate-to-severe ramifications to its overall operation, however, some were conveyed ahead of time to the Steer Protocol team to be promptly evaluated and remediated.

Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project was satisfactory to a certain extent, however, we strongly recommend it to be expanded at certain complex points such as the positional vault systems integrating with Uniswap V3.

A total of 66 findings were identified over the course of the manual review of which 43 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.

The finding table below enumerates all these security / behavioural findings:

IDSeverityAddressedTitle
BLM-01MInexistent Initialization of Base Implementation
BMR-01MInexistent Initialization of Access Control / Ownable
BMR-02MInexistent Initialization of Base Implementation
BMR-03MInsufficient Data Deletion
BRY-01MInexistent Initialization of Base Implementation
BRY-02MWeak Validation of IPFS CIDv0
DJS-01MInexistent Initialization of Base Implementation
GVT-01MInexistent Initialization of Base Implementation
IGE-01MLogic Upgrade w/o Governance Approval
IGE-02MAbnormally Small Voting Delay
KRY-01MInexistent Initialization of Base Implementation
KRY-02MInexistent Sanitization of joiners
KRY-03MImproper Keeper Removal Methodology
MPL-01MInverse Check Application
MPL-02MWeak Relative Weight Evaluation
MPL-03MInexistent Sanitization of Position Validity
ORO-01MInexistent Initialization of Base Implementation
ORO-02MImproper Bitwise Operation
ORO-03MInexistent Prevention of Re-Entrancy
ORO-04MAction Hash Conflict
ORO-05MInexistent Protection of Target Address
SPL-01MUnprotected Inversion of Swap Amount
SPL-02MInverse Check Application
SRS-01MInexistent Initialization of Base Implementation
SRS-02MPotentially Insecure Accounting System
SRS-03MInexistent Validation of Pool Initialization
SRS-04MImproper Overwrite of Pending Rewards
SGE-01MLogic Upgrade w/o Governance Approval
SGE-02MInexistent Access Control of Internal Governance
SGE-03MAbnormally Small Voting Delay
SPY-01MInexistent Initialization of Base Implementation
SPY-02MInexistent Clearance of Approvals
STN-01MArbitrary Mint Capacity
STN-02MInexistent Initialization of Base Implementation
STN-03MPotentially Incompatible Flash Loan Mechanism
SRY-01MInexistent Initialization of Base Implementation
SRY-02MInexistent Sanitization of Max Gas
SRY-03MInexistent Validation of execBundle Validity
SRY-04MArbitrary Burn Functionality
TVR-01MImproper Change of Recipient
TVR-02MInexistent Guarantee of Vested Funds
VRY-01MInexistent Initialization of Base Implementation
WRY-01MInexistent Manager Deletion Workflow