Omniscia Steer Protocol Audit

Code Style

Code Style

During the manual portion of the audit, we identified 14 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
AMP-01CRedundant Parenthesis Statement
DSG-01CInefficient Code Structure
DSG-02CInefficient Separation of Logic
DSG-03CInefficient Variable Reads
DSG-04CRepetitive Value Literals
FMR-01CInefficient mapping Lookups
FMR-02CLoop Iterator Optimizations
FMR-03CSuboptimal Struct Declaration Styles
MPL-01CInexistent Error Messages
MPL-02CRedundant Parenthesis Statement
PSB-01CIncorrect Specification of Gap
PSM-01CRedundant Parenthesis Statements
SSG-01CInefficient Code Structure
SSG-02CRepetitive Value Literal