Omniscia Steer Protocol Audit
MultiPositionLiquidityManager Code Style Findings
MultiPositionLiquidityManager Code Style Findings
MPL-01C: Inexistent Error Messages
Type | Severity | Location |
---|---|---|
Code Style | MultiPositionLiquidityManager.sol:L105, L143, L294-L297 |
Description:
The linked require
checks have no error messages explicitly defined.
Example:
contracts/vault-types/UniLiquidityManager/MultiPositionLiquidityManager.sol
105require(totalWeight <= TOTAL_WEIGHT_MAX);
Recommendation:
We advise each to be set so to increase the legibility of the codebase and aid in validating the require
checks' conditions.
Alleviation (6513a21a002d422e298719b22f73a4559dfd4663):
The Steer Protocol team evaluated this exhibit and due to contract size constraints has opted not to supply explicit error messages.
As alleviation of this exhibit would result in a breach of the contract's size limitation, we consider it inapplicable.
MPL-02C: Redundant Parenthesis Statement
Type | Severity | Location |
---|---|---|
Code Style | MultiPositionLiquidityManager.sol:L54 |
Description:
The referenced statement is redundantly wrapped in parenthesis (()
).
Example:
contracts/vault-types/UniLiquidityManager/MultiPositionLiquidityManager.sol
54return (_positions);
Recommendation:
We advise them to be safely omitted, increasing the legibility of the codebase.
Alleviation (6513a21a002d422e298719b22f73a4559dfd4663):
The redundant parenthesis in the referenced statement have been safely omitted.