Omniscia Ultra Yield Audit

Code Style

Code Style

During the manual portion of the audit, we identified 20 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
AUS-01CStructure Tight-Packing
BCA-01CNon-Standard Usage of Library
BCA-02CRedundant External Self-Calls
UFR-01CNon-Standard Usage of Library
UVT-01CIllegible Numeric Value Representations
UVT-02CNon-Standard Usage of Library
UVT-03CRepetitive Value Literal
UVO-01CCalculation Simplification
UVO-02CIneffective Boolean Flag Management
UVO-03CIneffectual Usage of Safe Arithmetics
UVO-04CRedundant Precision Concept
UVO-05CRepetitive Value Literal
UVR-01CIneffectual Usage of Safe Arithmetics
UVR-02CInexecutable Code
UVR-03COptimization of Yielded Statement
UVR-04CRepetitive Invocations of Storage Offset
VPM-01CInefficient Event Argument
VPM-02CInefficient Imposition of Access Control
VPM-03CInefficient mapping Lookups
VPM-04CRepetitive Value Literal