Omniscia Ultra Yield Audit
UltraFeeder Code Style Findings
UltraFeeder Code Style Findings
UFR-01C: Non-Standard Usage of Library
| Type | Severity | Location |
|---|---|---|
| Code Style |  | UltraFeeder.sol: • I-1: L163 • I-2: L178 |
Description:
The referenced statements will utilize the SafeERC20 library via direct invocations rather than applying the library to the IERC20 data type and utilizing it through it.
Example:
src/vaults/UltraFeeder.sol
163SafeERC20.safeIncreaseAllowance(IERC20(_asset), address(_mainVault), assets);Recommendation:
We advise the using SafeERC20 for IERC20 statement to be introduced to the codebase and the relevant functions to be invoked via the IERC20 data type, standardizing the code's syntax.
Alleviation (28f27853965de07fb79f4f2b5fed696d35120032):
All referenced library invocation instances have been properly replaced by invocations of the relevant functions directly through the data types involved, addressing this exhibit.