Omniscia Ultra Yield Audit
OracleAdmin Static Analysis Findings
OracleAdmin Static Analysis Findings
OAN-01S: Inexistent Sanitization of Input Address
| Type | Severity | Location |
|---|---|---|
| Input Sanitization |  | OracleAdmin.sol:L43-L45 |
Description:
The linked function accepts an address argument yet does not properly sanitize it.
Impact:
The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.
Example:
src/oracles/OracleAdmin.sol
43constructor(address _oracle, address _owner) Ownable(_owner) {44 oracle = IUltraVaultOracle(_oracle);45}Recommendation:
We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.
Alleviation (28f27853965de07fb79f4f2b5fed696d35120032):
The input _oracle address argument of the OracleAdmin::constructor function is adequately sanitized as non-zero in the latest in-scope revision of the codebase, addressing this exhibit.