Omniscia Tokemak Network Audit
Manual Review
Manual Review
A thorough line-by-line review was conducted on the codebase to identify potential malfunctions and vulnerabilities in Tokemak's capital management protocol.
As the project at hand implements a capital management system, intricate care was put into ensuring that the flow of funds within the system conforms to the specifications and restrictions laid forth within the protocol's specification.
We validated that all state transitions of the system occur within sane criteria and that all rudimentary formulas within the system execute as expected. We pinpointed a severe vulnerability within the system in the handling of deposited funds within DefiRound
which could have had severe ramifications to its overall operation, however, they were conveyed ahead of time to the Tokemak team to be promptly remediated.
Additionally, the system was investigated for any other commonly present attack vectors such as re-entrancy attacks, mathematical truncations, logical flaws and ERC / EIP standard inconsistencies. The documentation of the project covered a satisfactory extent of its functionality.
A total of 27 findings were identified over the course of the manual review of which 12 findings concerned the behaviour and security of the system. The non-security related findings, such as optimizations, are included in the separate Code Style chapter.
The finding table below enumerates all these security / behavioural findings:
ID | Severity | Addressed | Title |
---|---|---|---|
DRD-01M | Major | Yes | Improper Token Sanitization |
DRD-02M | Minor | Yes | Potential for Lock of Ether |
DRD-03M | Informational | Yes | Potentially Locked Ether |
EPL-01M | Medium | Yes | Inapplicacy of Checks-Effects-Interactions Pattern |
EPL-02M | Minor | Yes | Incorrect allowance Arguments |
EPL-03M | Minor | No | Potential for Lock of Ether |
POO-01M | Minor | Yes | Incorrect allowance Arguments |
RED-01M | Medium | Yes | Inexplicable Functionality |
REW-01M | Minor | No | Improper Cross Chain Replay Attack Protection |
REW-02M | Minor | Yes | Non-Standard Nonce System |
REW-03M | Minor | Yes | Signature Malleability |
TOK-01M | Major | Yes | Improper Usage of Inheritence |