Omniscia Tokemak Network Audit
Manager Static Analysis Findings
Manager Static Analysis Findings
MAN-01S: Dead Code
Type | Severity | Location |
---|---|---|
Gas Optimization | Informational | Manager.sol:L35, L36 |
Description:
The linked variables remain unutilized within the contract.
Example:
contracts/manager/Manager.sol
33uint256 public currentCycle;34uint256 public currentCycleIndex;35uint256 public deployedBlock;36uint256 public currentlyDeployingCycle;37uint256 public cycleDuration;
Recommendation:
We advise them to be omitted from the codebase.
Alleviation:
Both variables were safely omitted from the codebase.
MAN-02S: Literal Boolean Comparison
Type | Severity | Location |
---|---|---|
Code Style | Informational | Manager.sol:L148 |
Description:
The linked statement performs a literal comparison of a bool
variable and the value of true
.
Example:
contracts/manager/Manager.sol
148if (params.complete == true) {149 _completeRollover(params.rewardsIpfsHash);150}
Recommendation:
We advise the variable to be used directly as it already represents a bool
.
Alleviation:
The literal comparison was replaced by the raw utilization of the variable.