Pool Manual Review Findings

POO-01M: Incorrect allowance Arguments

Description:

The arguments for the allowance call are incorrect.

Example:

Copy
128function approveManager(address account, uint256 amount) external override onlyOwner {
129    uint256 currentAllowance = underlyer.allowance(account, account);
130    if (currentAllowance < amount) {
131        underlyer.safeIncreaseAllowance(account, type(uint256).max.sub(currentAllowance));
132    }
133}

Recommendation:

We advise the address(this) argument to be passed in the allowance call as the first argument to properly enforce the logic of the function.

Alleviation:

The allowance arguments were updated to the correct variables.