Omniscia AllianceBlock Audit

Code Style

Code Style

During the manual portion of the audit, we identified 24 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
ASP-01CGeneric Typographic Mistake
ASP-02CRedundant Code Structure
CCI-01CInefficient Iterator Increment Statements
CCI-02CInefficient Loop Implementation
CCI-03CLoop Iterator Optimization
CCI-04CSuboptimal Struct Declaration Style
DLF-01CLoop Iterator Optimizations
FCF-01CNon-Standard Invocation of Libraries
FCF-02CRedundant Parenthesis Statement
GEL-01CInefficient Library Implementation
GEL-02CLoop Iterator Optimizations
GEL-03CNon-Standard Invocation of Library
GFT-01CInexistent Error Message
GFT-02CLoop Iterator Optimization
LDD-01CLoop Iterator Optimizations
LFC-01CPotentially Inefficient Gain Accumulation
LGE-01CRedundant Library Usage Statement
LTT-01CInefficient Iterator Increment Statements
MPP-01CSuboptimal Struct Declaration Style
MWD-01CInefficient Configuration of Default Provider
MWD-02CInefficient Performance of External Call
M2L-01CLoop Iterator Optimizations
M2L-02CSuboptimal Struct Declaration Style
UFT-01CLoop Iterator Optimization