Omniscia AllianceBlock Audit
Code Style
Code Style
During the manual portion of the audit, we identified 24 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
ID | Severity | Addressed | Title |
---|---|---|---|
ASP-01C | ![]() | ![]() | Generic Typographic Mistake |
ASP-02C | ![]() | ![]() | Redundant Code Structure |
CCI-01C | ![]() | ![]() | Inefficient Iterator Increment Statements |
CCI-02C | ![]() | ![]() | Inefficient Loop Implementation |
CCI-03C | ![]() | ![]() | Loop Iterator Optimization |
CCI-04C | ![]() | ![]() | Suboptimal Struct Declaration Style |
DLF-01C | ![]() | ![]() | Loop Iterator Optimizations |
FCF-01C | ![]() | ![]() | Non-Standard Invocation of Libraries |
FCF-02C | ![]() | ![]() | Redundant Parenthesis Statement |
GEL-01C | ![]() | ![]() | Inefficient Library Implementation |
GEL-02C | ![]() | ![]() | Loop Iterator Optimizations |
GEL-03C | ![]() | ![]() | Non-Standard Invocation of Library |
GFT-01C | ![]() | ![]() | Inexistent Error Message |
GFT-02C | ![]() | ![]() | Loop Iterator Optimization |
LDD-01C | ![]() | ![]() | Loop Iterator Optimizations |
LFC-01C | ![]() | ![]() | Potentially Inefficient Gain Accumulation |
LGE-01C | ![]() | ![]() | Redundant Library Usage Statement |
LTT-01C | ![]() | ![]() | Inefficient Iterator Increment Statements |
MPP-01C | ![]() | ![]() | Suboptimal Struct Declaration Style |
MWD-01C | ![]() | ![]() | Inefficient Configuration of Default Provider |
MWD-02C | ![]() | ![]() | Inefficient Performance of External Call |
M2L-01C | ![]() | ![]() | Loop Iterator Optimizations |
M2L-02C | ![]() | ![]() | Suboptimal Struct Declaration Style |
UFT-01C | ![]() | ![]() | Loop Iterator Optimization |