Omniscia AllianceBlock Audit
UtilityFacet Static Analysis Findings
UtilityFacet Static Analysis Findings
UFT-01S: Inexistent Event Emission
Type | Severity | Location |
---|---|---|
Language Specific | ![]() | UtilityFacet.sol:L48-L57 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/facets/UtilityFacet.sol
48function setProviderSelector(49 address providerSelector_,50 bytes[] calldata signatures_51)52 external53 override54 onlyConsensusNonce(computeSetProviderSelectorMessage(providerSelector_), signatures_)55{56 LibTeleport.teleportStorage().providerSelector = providerSelector_;57}
Recommendation:
We advise an event
to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (54fd570de24631ca65a7cea022aebe43225a08c7):
The ProviderSelectorSet
event was introduced to the codebase and is correspondingly emitted in the UtilityFacet::setProviderSelector
function, addressing this exhibit in full.