Omniscia Evergon Labs Audit
Code Style
Code Style
During the manual portion of the audit, we identified 85 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| ACS-01C |  |  | Non-Standard Storage Slot Definition |
| ACS-02C | | | Non-Streamlined Code |
| ACS-03C | | | Potentially Inefficient Mapping Layouts |
| ACS-04C | | | Reduced Legibility of Conditionals |
| ACS-05C | | | Repetitive Invocations of Layout |
| CCN-01C | | | Generic Typographic Mistake |
| CCN-02C | | | Inefficient mapping Lookups |
| CCI-01C | | | Generic Typographic Mistake |
| CCI-02C | | | Inefficient mapping Lookups |
| CCS-01C | | | Non-Standard Storage Slot Definition |
| CRF-01C | | | Non-Standard Storage Slot Definition |
| CRF-02C | | | Repetitive Value Literals |
| CRF-03C | | | Test Dependency Import |
| CVF-01C | | | Inefficient Code Structure |
| CVF-02C | | | Non-Standard Storage Slot Definition |
| CVF-03C | | | Repetitive Value Literal |
| CVM-01C | | | Inefficient Code Structure |
| CVM-02C | | | Non-Standard Storage Slot Definition |
| CVM-03C | | | Repetitive Value Literal |
| ERF-01C | | | Inexistent Specification of Memory Safety |
| ERF-02C | | | Non-Standard Storage Slot Definition |
| ERU-01C | | | Error Ambiguity |
| EIG-01C | | | Inefficient ABI Encoding Mechanism |
| EIG-02C | | | Non-Standard Storage Slot Definition |
| EIG-03C | | | Repetitive Value Literal |
| ERG-01C | | | Inefficient ABI Encoding Mechanism |
| ERG-02C | | | Inefficient mapping Lookups |
| ERG-03C | | | Non-Standard Storage Slot Definition |
| ERG-04C | | | Repetitive Value Literal |
| ERO-01C | | | Inefficient ABI Encoding Mechanism |
| ERO-02C | | | Non-Standard Storage Slot Definition |
| ERO-03C | | | Repetitive Value Literal |
| EIS-01C | | | Inefficient ABI Encoding Mechanism |
| EIS-02C | | | Non-Standard Storage Slot Definition |
| EIS-03C | | | Repetitive Value Literal |
| ERS-01C | | | Inefficient ABI Encoding Mechanism |
| ERS-02C | | | Inefficient mapping Lookups |
| ERS-03C | | | Non-Standard Storage Slot Definition |
| ERS-04C | | | Repetitive Value Literal |
| ERR-01C | | | Inefficient ABI Encoding Mechanism |
| ERR-02C | | | Non-Standard Storage Slot Definition |
| ERR-03C | | | Repetitive Value Literal |
| GSE-01C | | | Non-Standard Storage Slot Definition |
| HAS-01C | | | Non-Standard Storage Slot Definition |
| HAS-02C | | | Repetitive Value Literal |
| IVF-01C | | | Inefficient Code Structure |
| IVF-02C | | | Non-Standard Storage Slot Definition |
| IVF-03C | | | Repetitive Value Literal |
| IVM-01C | | | Inefficient Code Structure |
| IVM-02C | | | Non-Standard Storage Slot Definition |
| IVM-03C | | | Repetitive Value Literal |
| OST-01C | | | Repetitive Value Literal |
| PSD-01C | | | Non-Standard Storage Slot Definition |
| PSD-02C | | | Repetitive Invocations of Layout |
| PSD-03C | | | Repetitive Value Literal |
| RBL-01C | | | Generic Typographic Mistake |
| RBR-01C | | | Inefficient Loop Structure |
| RBR-02C | | | Non-Standard Storage Slot Definition |
| RBR-03C | | | Repetitive Value Literal |
| RBD-01C | | | Inefficient Loop Structure |
| RBD-02C | | | Non-Standard Storage Slot Definition |
| RBD-03C | | | Repetitive Value Literal |
| SSN-01C | | | Potential Optimization of NFT IDs |
| SSN-02C | | | Redundant Parenthesis Statement |
| SSN-03C | | | Repetitive Value Literal |
| SSI-01C | | | Potential Optimization of NFT IDs |
| SSI-02C | | | Redundant Parenthesis Statement |
| SSI-03C | | | Repetitive Value Literal |
| SPF-01C | | | Inefficient mapping Lookups |
| SPF-02C | | | Non-Standard Storage Slot Definition |
| SPF-03C | | | Repetitive Value Literal |
| TIS-01C | | | Non-Standard Storage Slot Definition |
| TIS-02C | | | Repetitive Value Literal |
| TRS-01C | | | Non-Standard Storage Slot Definition |
| TBF-01C | | | Ineffectual Usage of Safe Arithmetics |
| TBF-02C | | | Non-Standard Storage Slot Definition |
| TBF-03C | | | Repetitive Value Literal |
| TBL-01C | | | Non-Standard Storage Slot Definition |
| TBL-02C | | | Repetitive Value Literal |
| TBC-01C | | | Repetitive Value Literal |
| WCS-01C | | | Inefficient Array Assignment |
| WCS-02C | | | Non-Standard Storage Slot Definition |
| WSS-01C | | | Inefficient Array Assignment |
| WSS-02C | | | Non-Standard Storage Slot Definition |
| WSS-03C | | | Repetitive Value Literal |