NoVirtualLockMultiplierFacet Manual Review Findings

NVL-01M: Inexistent Satisfaction of Full Interface

Type	Severity	Location
Logical Fault		NoVirtualLockMultiplierFacet.sol:L17

Description:

The lock period based multiplier facets appear to satisfy the IVirtualLockMultiplierFacet::combineVirtualLockMultipliers function, however, the NoVirtualLockMultiplierFacet implementation appears to not implement it thereby causing the facet's integration to fail as a no-multiplier implementation.

Impact:

The NoVirtualLockMultiplierFacet cannot be utilized as a proper no-multiplier implementation.

Example:

Copy
17contract NoVirtualLockMultiplierFacet is DelegateCallee {

Recommendation:

We advise the relevant function to be properly implemented, yielding a value of 1e18 similarly to the other functions implemented by the contract.

Alleviation (b64b659786cf3c84bea52feb3a69f546ba3601f0):

The NoVirtualLockMultiplierFacet::combineVirtualLockMultipliers function was properly introduced to the facet ensuring that it is compatible with the expected function selectors and thus addressing this exhibit in full.