Omniscia Evergon Labs Audit

TwoBorderTimestampCampaign Code Style Findings

TwoBorderTimestampCampaign Code Style Findings

TBC-01C: Repetitive Value Literal

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

packages/contracts/contracts/campaignTimes/twoBorderTimestampCampaign/TwoBorderTimestampCampaign.sol
85if (campaignsInfo.state != 1) {

Recommendation:

We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.

In case the constant has already been declared, we advise it to be properly re-used across the code.

Alleviation (b64b659786cf3c84bea52feb3a69f546ba3601f0):

The referenced literal has been properly introduced as part of the GeneralStakingStorage declarations and specifically as an ON_CREATION state, addressing this exhibit.