Omniscia Evergon Labs Audit
StaticPeriodLockFacetStorage Code Style Findings
StaticPeriodLockFacetStorage Code Style Findings
SPF-01C: Inefficient mapping Lookups
| Type | Severity | Location |
|---|---|---|
| Gas Optimization |  | StaticPeriodLockFacetStorage.sol:L137 |
Description:
The linked statements perform key-based lookup operations on mapping declarations from storage multiple times for the same key redundantly.
Example:
130for (uint256 i; i < length; i++) {131 uint256 lockPeriod = lockPeriods[i];132
133 if (lockPeriod > maxLockPeriod) {134 revert ExceedsMaxAllowedLockPeriod(campaignId, lockPeriod, maxLockPeriod);135 }136
137 l.isLockPeriodSupportedForCampaign[campaignId][lockPeriod] = true;138}Recommendation:
As the lookups internally perform an expensive keccak256 operation, we advise the lookups to be cached wherever possible to a single local declaration that either holds the value of the mapping in case of primitive types or holds a storage pointer to the struct contained.
As the compiler's optimizations may take care of these caching operations automatically at-times, we advise the optimization to be selectively applied, tested, and then fully adopted to ensure that the proposed caching model indeed leads to a reduction in gas costs.
Alleviation (b64b659786cf3c84bea52feb3a69f546ba3601f0):
All referenced inefficient mapping lookups have been optimized to the greatest extent possible, significantly reducing the gas cost of the functions the statements were located in.
SPF-02C: Non-Standard Storage Slot Definition
| Type | Severity | Location |
|---|---|---|
| Standard Conformity | | StaticPeriodLockFacetStorage.sol:L43 |
Description:
The referenced declaration will define a storage slot for use by a facet of the system's main EIP-2535 Diamond, however, the way it is declared does not adhere to the latest standards.
Example:
41/// @dev Unique identifier for the storage slot where the Layout struct is stored.42bytes32 internal constant STORAGE_SLOT =43 keccak256("evergonlabs.Staking.lockVariations.storage.StaticPeriodLockFacetStorage");Recommendation:
We advise the EIP-7201 name-spaced layout approach to be adhered to similarly to OpenZeppelin and other relevant standard libraries, ensuring consistency among the ecosystem's widely utilized libraries and conforming to the latest standards.
Alleviation (b64b659786cf3c84bea52feb3a69f546ba3601f0):
The referenced slot definition has been updated to its standardized EIP-7201 representation, addressing this exhibit.
SPF-03C: Repetitive Value Literal
| Type | Severity | Location |
|---|---|---|
| Code Style | | StaticPeriodLockFacetStorage.sol:L116 |
Description:
The linked value literal is repeated across the codebase multiple times.
Example:
116if (GeneralStorage.layout().campaignsInfo[campaignId].state != 1) {Recommendation:
We advise it to be set to a constant variable instead, optimizing the legibility of the codebase.
In case the constant has already been declared, we advise it to be properly re-used across the code.
Alleviation (b64b659786cf3c84bea52feb3a69f546ba3601f0):
The referenced literal has been properly introduced as part of the GeneralStakingStorage declarations and specifically as an ON_CREATION state, addressing this exhibit.