Omniscia Mantissa Finance Audit

Code Style

Code Style

During the manual portion of the audit, we identified 20 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.

Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.

These optimizations are enumerated below:

IDSeverityAddressedTitle
CON-01CGeneric Typographic Mistakes
CON-02CLoop Iterator Optimizations
MEC-01CInefficient mapping Lookups
MEC-02CRepetitive Value Literals
MMS-01CInefficient Square Root Implementation
MMS-02CInefficient Update of Pools
MMS-03CLoop Iterator Optimizations
MMS-04CRepetitive Value Literal
PLO-01CLoop Iterator Optimization
PHR-01CDeprecated Representation of Maximum
PHR-02CDocumentation Discrepancy
PHR-03CRepetitive Value Literal
PVE-01CLoop Iterator Optimization
RRE-01CIneffectual Usage of Safe Arithmetics
RRE-02CRedundant Casting Operation
VGN-01CIneffectual Usage of Safe Arithmetics
MNE-01CLoop Iterator Optimizations
MNE-02CPotentially Redundant Shift Operation
MNE-03CRedundant Parenthesis Statement
MNE-04CRepetitive Value Literal