Omniscia Mantissa Finance Audit

LP Manual Review Findings

LP Manual Review Findings

CON-01M: Inexistent Initialization Protection of Base Implementation

TypeSeverityLocation
Language SpecificLP.sol:L12

Description:

The contract is meant to be upgradeable yet does not properly protect its logic deployment from malicious initializations.

Example:

contracts/LP.sol
12contract LP is Initializable, Ownable, ERC20, ILP {

Recommendation:

We advise a constructor to be introduced that either invokes the initializer modifier of the Initializable contract or invokes the Initializable::_disableInitializers function to prevent the base implementation from ever being initialized.

Alleviation (418ee413ad8e26f7eea383764c19953ff31b2bf3):

The Mantissa Finance evaluated this exhibit and stated that they wish to acknowledge it and that they will ensure the logic deployments are properly initialized whenever they are deployed.