Omniscia Mantissa Finance Audit
LP Static Analysis Findings
LP Static Analysis Findings
CON-01S: Inexistent Event Emission
Type | Severity | Location |
---|---|---|
Language Specific | LP.sol:L100-L102 |
Description:
The linked function adjusts a sensitive contract variable yet does not emit an event for it.
Example:
contracts/LP.sol
100function setLiabilityLimit(uint256 _liabilityLimit) external onlyOwner {101 liabilityLimit = _liabilityLimit;102}
Recommendation:
We advise an event
to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.
Alleviation (418ee413ad8e26f7eea383764c19953ff31b2bf3):
The Mantissa Finance evaluated this exhibit and given that it has no security implications opted not to apply it to avoid updating the on-chain contracts and / or introducing significant complexity to existing deployments. As such, we consider this exhibit acknowledged.