Omniscia Mantissa Finance Audit
Pool Static Analysis Findings
Pool Static Analysis Findings
PLO-01S: Inexistent Event Emissions
Type | Severity | Location |
---|---|---|
Language Specific | Pool.sol:L121-L123, L125-L127, L129-L131, L139-L141, L158-L161 |
Description:
The linked functions adjust sensitive contract variables yet do not emit an event for it.
Example:
contracts/Pool.sol
121function setPoolHelper(address _poolHelper) external onlyOwner checkNullAddress(_poolHelper) {122 poolHelper = IPoolHelper(_poolHelper);123}
Recommendation:
We advise an event
to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.
Alleviation (418ee413ad8e26f7eea383764c19953ff31b2bf3):
All referenced setter functions have had a corresponding event
declared and emitted whenever they are invoked, addressing this exhibit in full.