Omniscia Tangible Audit
Code Style
Code Style
During the manual portion of the audit, we identified 48 optimizations that can be applied to the codebase that will decrease the operational cost associated with the execution of a particular function and generally ensure that the project complies with the latest best practices and standards in Solidity.
Additionally, this section of the audit contains any opinionated adjustments we believe the code should make to make it more legible as well as truer to its purpose.
These optimizations are enumerated below:
| ID | Severity | Addressed | Title |
|---|---|---|---|
| CFV-01C |  |  | Optimization of Currency & Country Alpha Codes |
| EEG-01C | |  | Inefficient mapping Lookups |
| EEG-02C | |  | Sub-Optimal Inverse Route Management |
| FMS-01C | | | Generic Typographic Mistake |
| FV2-01C | | | Ineffectual Usage of Safe Arithmetics |
| FV2-02C | | | Inefficient mapping Lookups |
| FV2-03C | | | Loop Iterator Optimization |
| FV2-04C | | | Redundant Conditional Evaluation |
| FV2-05C | | | Redundant Parenthesis Statements |
| FV2-06C | | | Sub-Optimal Fetching of Price |
| FV2-07C | | | Unreachable Code |
| GOT-01C | | | Generic Typographic Mistake |
| GOT-02C | | | Inefficient mapping Lookups |
| GOT-03C | | | Loop Iterator Optimization |
| GOT-04C | | | Redundant Parenthesis Statements |
| GOT-05C | | | Redundant Ternary Operator |
| MV2-01C | | | Inefficient Repetitive Invocations of Getter Function |
| MV2-02C | | | Inefficient mapping Lookups |
| MV2-03C | | | Redundant Parenthesis Statements |
| MV2-04C | | | Suboptimal Struct Declaration Style |
| OST-01C | | | Inefficient Array Shifts |
| OST-02C | | | Inefficient mapping Lookups |
| OST-03C | | | Inexistent Error Message |
| OST-04C | | | Redundant Parenthesis Statement |
| OST-05C | | | Suboptimal Struct Declaration Styles |
| PCR-01C | | | Ineffectual Usage of Safe Arithmetics |
| ROV-01C | | | Inefficient Fetching of First Entry |
| ROV-02C | | | Redundant Ternary Operator |
| RMR-01C | | | Redundant Separation of Declaration & Assignment |
| RMR-02C | | | Unreachable Code |
| RMD-01C | | | Redundant Interface Member Instantiation |
| RND-01C | | | Multiple Redundant Invocations of Getter Function |
| SFD-01C | | | Redundant Parenthesis Statements |
| TNF-01C | | | Inefficient Array Shifts |
| TNF-02C | | | Inefficient Index Sequence |
| TNF-03C | | | Inefficient Loop Limit Evaluation |
| TNF-04C | | | Inefficient mapping Lookups |
| TNF-05C | | | Inexistent Error Message |
| TNG-01C | | | Generic Typographic Mistakes |
| TNG-02C | | | Redundant Code Duplication |
| TNT-01C | | | Inefficient Array Shift |
| TNT-02C | | | Inefficient Conditional Clauses |
| TNT-03C | | | Inefficient mapping Lookups |
| TNT-04C | | | Redundant Parenthesis Statement |
| TRH-01C | | | Variable Mutability Specifiers (Immutable) |
| UUO-01C | | | Generic Typographic Mistake |
| UUO-02C | | | Inefficient Usage of Storage Variable |
| UUO-03C | | | Repetitive Value Literal |