Omniscia Tangible Audit

UsdUsdOracle Manual Review Findings

UsdUsdOracle Manual Review Findings

UUO-01M: Mismatch of Function Specification

Description:

The UsdUsdOracle::latestAnswer function does not match its specification, applying no form of access control nor yielding 0.

Impact:

The severity of this exhibit will be adjusted according to the actions the Tangible takes to remediate them.

Example:

contracts/priceOracles/UsdUsdOracle.sol
114/**
115 * @notice Reads the current answer from aggregator delegated to.
116 * @dev overridden function to add the checkAccess() modifier
117 *
118 * @dev #[deprecated] Use latestRoundData instead. This does not error if no
119 * answer has been reached, it will simply return 0. Either wait to point to
120 * an already answered Aggregator or use the recommended latestRoundData
121 * instead which includes better verification information.
122 */
123function latestAnswer() public view override returns (int256) {
124 return 1;
125}

Recommendation:

We advise either the documentation or the implementation to be updated accordingly, addressing this exhibit.

Alleviation (2ad448279d9e8e4b6edd94bcd2eb22129b6f7357):

The function's specification has been updated to match its implementation, rendering this exhibit dealt with.