RethOracle Code Style Findings

ROE-01C: Potential Usage of Library

Type	Severity	Location
Code Style		RethOracle.sol:L32, L34, L37

Description:

The referenced statements can be executed via the ScaleUtils::getDirectionOrRevert function.

Example:

Copy
32if (base == reth && quote == weth) {
33    return IReth(reth).getEthValue(inAmount);
34} else if (base == weth && quote == reth) {
35    return IReth(reth).getRethValue(inAmount);
36}
37revert Errors.PriceOracle_NotSupported(base, quote);

Recommendation:

We advise this to be done so, optimizing the code's legibility.

Alleviation:

The Euler Finance team has proceeded with removing the RethOracle from the codebase in light of exhibit ROE-01M, rendering this exhibit no longer applicable.