RethOracle Static Analysis Findings

ROE-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		RethOracle.sol:L20-L23

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

Copy
20constructor(address _weth, address _reth) {
21    weth = _weth;
22    reth = _reth;
23}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

Alleviation:

The Euler Finance team has proceeded with removing the RethOracle from the codebase in light of exhibit ROE-01M, rendering this exhibit no longer applicable.